Skip to content

[TST] Fix for Issue #1184 #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 7, 2022
Merged

[TST] Fix for Issue #1184 #1186

merged 7 commits into from
Nov 7, 2022

Conversation

@samukweku
Copy link
Collaborator

@samukweku samukweku commented Nov 1, 2022 •
edited
Loading

PR Description

Please describe the changes proposed in the pull request:

  • Fix test fail for test_fill_missing_timestamps by provide first_time_stamp and last_time_stamp

This PR resolves #1184 .

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@samukweku samukweku self-assigned this Nov 1, 2022
@samukweku samukweku changed the title [TST] Fix for GH#1184 [TST] Fix for Issue #1184 Nov 1, 2022
@ericmjl
Copy link
Member

ericmjl commented Nov 1, 2022 •
edited
Loading

🚀 Deployed on https://deploy-preview-1186--pyjanitor.netlify.app

@codecov
Copy link

codecov bot commented Nov 1, 2022 •
edited
Loading

Codecov Report

Merging #1186 (30b821b) into dev (32bd2ab) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1186      +/-   ##
==========================================
- Coverage   97.69%   97.66%   -0.03%     
==========================================
  Files          76       76              
  Lines        3474     3474              
==========================================
- Hits         3394     3393       -1     
- Misses         80       81       +1

@Zeroto521
Copy link
Member

I'll merge this PR into #1143. See what happens.
So let this PR just keep opening.

Zeroto521
Zeroto521 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@Zeroto521 Zeroto521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we go

@Zeroto521 Zeroto521 merged commit fe9fa5a into dev Nov 7, 2022
@Zeroto521 Zeroto521 deleted the samukweku/fill_timestamp branch November 7, 2022 01:31
samukweku added a commit that referenced this pull request Nov 28, 2022
@samukweku @ericmjl
[TST] Fix for Issue #1184 (#1186)
08c2c8b 
* add fix for GH#1184

* changelog

* fix grammar

* clearer comments

* update changelog

Co-authored-by: Eric Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericmjl ericmjl ericmjl approved these changes

@Zeroto521 Zeroto521 Zeroto521 approved these changes

@thatlittleboy thatlittleboy Awaiting requested review from thatlittleboy

Assignees

@samukweku samukweku

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] test_fill_missing_timestamps test case only failed windows-latest, 3.9, ci/envs/latest.yaml

3 participants

@samukweku @ericmjl @Zeroto521